From 3e04c8ac518774d4b5dd25baadd5974f0c8656bf Mon Sep 17 00:00:00 2001
From: Philipp Wo <psycho160@gmx.at>
Date: Tue, 21 Apr 2020 15:09:51 +0200
Subject: [PATCH] added foreach -> for

---
 98_TadoAPI.pm | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/98_TadoAPI.pm b/98_TadoAPI.pm
index 6df9c0c..5f9e319 100644
--- a/98_TadoAPI.pm
+++ b/98_TadoAPI.pm
@@ -159,7 +159,7 @@ sub TadoAPI_Set(@) {
 
   if(!defined($sets{$cmd})) {
   	my @cmds = ();
-    foreach my $key (sort keys %sets) {
+    for my $key (sort keys %sets) {
       push @cmds, $sets{$key} ? $key.":".join(",",$sets{$key}) : $key;
     }
     return "Unknown argument $a[1], choose one of " . join(" ", @cmds);
@@ -289,7 +289,7 @@ sub TadoAPI_Get(@) {
 
   if(!defined($gets{$cmd})) {
   	my @cmds = ();
-    foreach my $key (sort keys %gets) {
+    for my $key (sort keys %gets) {
       push @cmds, $gets{$key} ? $key.":".join(",",$gets{$key}) : $key;
     }
     return "Unknown argument $a[1], choose one of " . join(" ", @cmds);
@@ -320,7 +320,7 @@ sub TadoAPI_Get(@) {
         Log3 $name, 3, "TadoAPI $name" . ": " . "processing ($cmd)";
         my @data = TadoAPI_GetMobileDevices($hash);
         $message = "Device List:\n";
-        foreach my $item ( @data ){
+        for my $item ( @data ){
           $message .= $item->{'name'} . ": " . $item->{'id'} . "\n";
         };
         Log3 $name, 3, "TadoAPI $name" . ": " . "$cmd finished";
@@ -345,7 +345,7 @@ sub TadoAPI_Get(@) {
           my $tadodevices = $devArr[$i]->{'devices'};
           $message .= "ZoneID: " . ($devArr[$i]->{'id'});
           my $spacer = 0;
-          foreach my $item ( @$tadodevices ){
+          for my $item ( @$tadodevices ){
             $message .= "\t " if ($spacer > 0);
             $message .= " " . $item->{'serialNo'} . " Battery: " . $item->{'batteryState'} . "\n";
             $devicecount++;
@@ -730,7 +730,7 @@ sub TadoAPI_GetAllZoneOverlays(@){
   my $name = $hash->{NAME};
   my @zones = TadoAPI_GetTadoDevices($hash);
 
-  foreach my $zone ( @zones ){
+  for my $zone ( @zones ){
     my $zoneID = $zone->{'id'};
     my $zoneName = TadoAPI_ReplaceUmlaute($zone->{'name'});
     my ($temperature, $humidity, $desiredTemp, $currentHeatingPower, $overlay ) = TadoAPI_GetZoneReadingsById($hash, $zoneID);
@@ -822,7 +822,7 @@ sub TadoAPI_UpdateAllZoneReadingsCallback($){
       $hash->{LastRequest}="error";
     }else{
       readingsBeginUpdate($hash);
-      foreach my $zone ( @$decoded_data ){
+      for my $zone ( @$decoded_data ){
         my $zoneID = $zone->{'id'};
         my $zoneName = TadoAPI_ReplaceUmlaute($zone->{'name'});
         Log3 $name, 5, "TadoAPI $name" . ": " . "Set Reading Update for Zone $zoneID ";
@@ -838,7 +838,7 @@ sub TadoAPI_UpdateAllZoneReadingsCallback($){
 
         # iterate through all devices in zone
         my $devices = $zone->{'devices'};
-        foreach my $device ( @$devices ){
+        for my $device ( @$devices ){
           readingsBulkUpdate($hash, "Battery_" . $device->{'serialNo'}, $device->{'batteryState'});
         }
       }
@@ -952,7 +952,7 @@ sub TadoAPI_UpdateMobileReadingsCallback($){
       Log3 $name, 3, "TadoAPI $name" . ": " . "Error in UpdateMobileReadingsCallback, Code: " . $decoded_data->{'errors'}->[0]->{'code'};
       $hash->{LastRequest}="error";
     }else{
-      foreach my $item ( @$decoded_data ){
+      for my $item ( @$decoded_data ){
         TadoAPI_GetGeoById($hash, $item->{'id'}, $item);
       }
     }
@@ -1178,7 +1178,7 @@ sub TadoAPI_GetGeoById(@){
           Log3 $name, 3, "TadoAPI $name" . ": " . "GetGeoById: Error in UpdateMobileReadingsCallback, Code: " . $decoded_data->{'errors'}->[0]->{'code'};
           $hash->{LastRequest}="error";
         }else{
-          foreach my $item ( @$decoded_data ){
+          for my $item ( @$decoded_data ){
             if($item->{'id'} eq $mobileID){
               return my ($setting, $distance) = TadoAPI_ParseMobileItem($hash, $item);
             }
@@ -1254,7 +1254,7 @@ sub TadoAPI_GetMobileDevices(@) {
         Log3 $name, 3, "TadoAPI $name" . ": " . "GetMobileDevices: decode_json failed, invalid json. error:$@\n";
       }else{
         if(ref($decoded_data) eq 'ARRAY'){
-          foreach my $item( @$decoded_data ) {
+          for my $item( @$decoded_data ) {
             push @devices, $item;
           }
           # default case
@@ -1304,7 +1304,7 @@ sub TadoAPI_GetZoneCount(@) {
         Log3 $name, 3, "TadoAPI $name" . ": " . "GetZoneCount: decode_json failed, invalid json. error:$@\n";
       }else{
         if(ref($decoded_data) eq 'ARRAY'){
-          foreach my $item( @$decoded_data ) {
+          for my $item( @$decoded_data ) {
             $zonecount++;
           }
           return $zonecount;
@@ -1323,7 +1323,7 @@ sub TadoAPI_GetZoneNameById(@) {
   my $zoneName = undef;
   my @zones = TadoAPI_GetTadoDevices($hash);
 
-  foreach my $zone ( @zones ){
+  for my $zone ( @zones ){
     if ($zone->{'id'} == $zoneID){
       $zoneName = TadoAPI_ReplaceUmlaute($zone->{'name'});
       return $zoneName;
@@ -1422,7 +1422,7 @@ sub TadoAPI_GetTadoDevices(@) {
         }else{
           if(ref($decoded_data) eq 'ARRAY'){
           my @devices = ();
-          foreach my $dev (@$decoded_data){
+          for my $dev (@$decoded_data){
             push @devices, $dev;
           }
         return @devices;