Public/FHEM-Tado
1
0
Fork 0
Code Issues Pull Requests Releases 12 Activity

perlcritic -3; file handling now pbp

Browse Source
This commit is contained in:
Philipp Wo 2020-04-20 00:17:52 +02:00
parent ae011426b0
commit d9bfbd0038
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
98_TadoAPI.pm
View File

@ -420,9 +420,9 @@ sub TadoAPI_LoadToken(@){
my $Token = undef; my $Token = undef;
if($apiStatus){ if($apiStatus){
open(my $TOKENFILE, '<', $tokenFileName) or die("ERROR: $!"); open(my $TOKENFILE, q{<}, $tokenFileName) or croak("ERROR: $!");
eval { $Token = decode_json(<$TOKENFILE>)};
close($TOKENFILE); close($TOKENFILE);
eval { $Token = decode_json($TOKENFILE)};
if($@ || $tokenLifeTime < gettimeofday()){ if($@ || $tokenLifeTime < gettimeofday()){
Log3 $name, 5, "TadoAPI $name" . ": " . "Error while loading: $@ ,requesting new one" if $@; Log3 $name, 5, "TadoAPI $name" . ": " . "Error while loading: $@ ,requesting new one" if $@;
@ -485,7 +485,7 @@ sub TadoAPI_NewTokenRequest(@) {
Log3 $name, 3, "TadoAPI $name" . ": " . "NewTokenRequest: decode_json failed, invalid json. error: $@ "; Log3 $name, 3, "TadoAPI $name" . ": " . "NewTokenRequest: decode_json failed, invalid json. error: $@ ";
}else{ }else{
#write token data in file #write token data in file
open(my $TOKENFILE, q{>} ,$tokenFileName) or die("ERROR: $!"); open(my $TOKENFILE, q{>} ,$tokenFileName) or croak("ERROR: $!");
print $TOKENFILE $returnData . "\n"; print $TOKENFILE $returnData . "\n";
close($TOKENFILE); close($TOKENFILE);
@ -507,9 +507,9 @@ sub TadoAPI_TokenRefresh(@) {
my $Token = undef; my $Token = undef;
# load token # load token
open(my $TOKENFILE, '<', $tokenFileName) or die("ERROR: $!"); open(my $TOKENFILE, q{<}, $tokenFileName) or croak("ERROR: $!");
eval { $Token = decode_json(<$TOKENFILE>)};
close($TOKENFILE); close($TOKENFILE);
eval { $Token = decode_json($TOKENFILE)};
$data = { $data = {
client_id => $client_id, client_id => $client_id,
@ -547,7 +547,7 @@ sub TadoAPI_TokenRefresh(@) {
$hash->{STATE}="error"; $hash->{STATE}="error";
}else{ }else{
#write token data in file #write token data in file
open(my $TOKENFILE, q{>}, $tokenFileName) or die("ERROR: $!"); open(my $TOKENFILE, q{>}, $tokenFileName) or croak("ERROR: $!");
print $TOKENFILE $returnData . "\n"; print $TOKENFILE $returnData . "\n";
close($TOKENFILE); close($TOKENFILE);