From 2b8bb3881a1b38985c6348d3bae679cda349e442 Mon Sep 17 00:00:00 2001 From: hofrichter <> Date: Sat, 10 Jan 2015 17:48:15 +0000 Subject: [PATCH] 70_PIONEERAVR.pm: fixed "missed to call readingsBeginUpdate first" git-svn-id: https://svn.fhem.de/fhem/trunk@7499 2b470e98-0d58-463d-a4d8-8e2adae1ed80 --- fhem/CHANGED | 1 + fhem/FHEM/70_PIONEERAVR.pm | 12 ++++++------ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/fhem/CHANGED b/fhem/CHANGED index 0ce3c027e..0e6d8e2ea 100644 --- a/fhem/CHANGED +++ b/fhem/CHANGED @@ -1,5 +1,6 @@ # Add changes at the top of the list. Keep it in ASCII, and 80-char wide. # Do not insert empty lines here, update check depends on it. + - bugfix: 70_PIONEERAVR: fixed "missed to call readingsBeginUpdate first" - feature: fhemweb.js rewrite based on jQuery, single-widget-implementation - feature: SVG: multiple sources allowed, Plot-Editor - feature: textfield-long and knob widgets diff --git a/fhem/FHEM/70_PIONEERAVR.pm b/fhem/FHEM/70_PIONEERAVR.pm index cf0ae8205..649210ff8 100644 --- a/fhem/FHEM/70_PIONEERAVR.pm +++ b/fhem/FHEM/70_PIONEERAVR.pm @@ -1186,12 +1186,11 @@ sub PIONEERAVR_Read($) while($buf =~ m/^(.*?)\r\n(.*)\Z/s ) { my $line = $1; $buf = $2; - Log3 $name, 5, "PIONEERAVR $name: processing ". dq($line) ." received from PIONEERAVR"; - Log3 $name, 5, "PIONEERAVR $name: line to do soon: " . dq($buf) unless ($buf eq ""); + #Log3 $name, 5, "PIONEERAVR $name: line to do soon: " . dq($buf) unless ($buf eq ""); if (( $line eq "R" ) ||( $line eq "" )) { Log3 $hash, 5, "PIONEERAVR $name: Supressing received " . dq($line); - next; + next; # Main zone volume } elsif ( substr($line,0,3) eq "VOL" ) { my $volume = substr($line,3,3); @@ -1260,11 +1259,11 @@ sub PIONEERAVR_Read($) $hash->{helper}{main}{CURINPUTNR} = $inputNr; # if($inputNr != "17" and $inputNr != "44" and $inputNr != "45"){ - readingsBeginUpdate($hash); + #readingsBeginUpdate($hash); foreach my $key ( keys %{$hash->{helper}{LINEDATATYPES}} ) { readingsBulkUpdate($hash, $hash->{helper}{LINEDATATYPES}->{$key} , ""); } - readingsEndUpdate($hash, 1); + #readingsEndUpdate($hash, 1); # input names # RGBXXY(14char) # XX -> input number @@ -1607,7 +1606,7 @@ sub PIONEERAVR_Read($) # model } elsif ( $line =~ m/^RGD<\d{3}><(.*)\/.*>$/ ) { - $hash->{model}= $1; + #$hash->{model}= $1; Log3 $hash,5,"PIONEERAVR $name: ".dq($line) ." interpreted as: Model is " . $1; # Software version @@ -1679,6 +1678,7 @@ sub PIONEERAVR_Read($) # dispatch "zone" - commands to other zones Dispatch($hash, $line, undef); # dispatch result to PIONEERAVRZONEs Log3 $hash,5,"PIONEERAVR $name: ".dq($line) ." interpreted as: not for the Main zone -> dispatch to PIONEERAVRZONEs zone: $msgForZone"; + $msgForZone = ""; } } # Connection still up?