From 422f9e22bfec1409d04a1d44c1a0b02a39bd5771 Mon Sep 17 00:00:00 2001
From: rudolfkoenig <>
Date: Mon, 30 Mar 2020 20:37:31 +0000
Subject: [PATCH] fhem.pl: another fix for attr -a/-r (Forum #109678)

git-svn-id: https://svn.fhem.de/fhem/trunk/fhem@21548 2b470e98-0d58-463d-a4d8-8e2adae1ed80
---
 fhem.pl | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/fhem.pl b/fhem.pl
index 891956aa1..41aea3d63 100755
--- a/fhem.pl
+++ b/fhem.pl
@@ -2873,7 +2873,7 @@ CommandAttr($$)
   @a = split(" ", $param, 3) if($param);
 
   return "Usage: attr [-a|-r] <name> <attrname> [<attrvalue>]\n$namedef"
-           if(@a < 2);
+           if(@a < 2 || ($append && $remove));
   my $a1 = $a[1];
   return "$a[0]: bad attribute name '$a1' (allowed chars: A-Za-z/\\d_\\.-)"
            if($featurelevel > 5.9 && !goodReadingName($a1) && $a1 ne "?");
@@ -2917,12 +2917,11 @@ CommandAttr($$)
     if($append && $attr{$sdev} && $attr{$sdev}{$attrName}) {
       $attrVal = $attr{$sdev}{$attrName} . 
                         ($attrVal =~ m/^,/ ? $attrVal : " $attrVal");
-
-    } elsif($remove && $attr{$sdev} && $attr{$sdev}{$attrName}) {
+    }
+    if($remove && $attr{$sdev} && $attr{$sdev}{$attrName}) {
       my $v = $attr{$sdev}{$attrName};
       $v =~ s/\b$attrVal\b//;
       $attrVal = $v;
-
     }
 
     if($attrName eq 'disable' && $attrVal eq 'toggle') {