From 65e28eb1912bf397f0f5412c8876cd6ab9034709 Mon Sep 17 00:00:00 2001 From: justme-1968 Date: Mon, 1 Mar 2021 08:27:35 +0000 Subject: [PATCH] 34_SWAP.pm: fixed my $var = ... if( ... ); git-svn-id: https://svn.fhem.de/fhem/trunk@23870 2b470e98-0d58-463d-a4d8-8e2adae1ed80 --- fhem/FHEM/34_SWAP.pm | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/fhem/FHEM/34_SWAP.pm b/fhem/FHEM/34_SWAP.pm index ef52224ff..2e74ebade 100755 --- a/fhem/FHEM/34_SWAP.pm +++ b/fhem/FHEM/34_SWAP.pm @@ -642,7 +642,8 @@ Log 3, $value; } } elsif( $cmd eq "readDeviceXML" ) { - my $productcode = $attr{$name}{ProductCode} if( defined($attr{$name}{ProductCode} ) ); + my $productcode; + $productcode = $attr{$name}{ProductCode} if( defined($attr{$name}{ProductCode} ) ); if( defined($products->{$productcode} ) ) { SWAP_readDeviceXML( $hash, $productcode ); $hash->{product} = $products->{$productcode} if( defined($productcode) && defined($products->{$productcode} ) ); @@ -1171,7 +1172,8 @@ SWAP_ProcessCmdStack($) my $sent; if($hash->{cmdStack}) { if(@{$hash->{cmdStack}}) { - my $params = shift @{$hash->{cmdStack}}; + my $params; + $params = shift @{$hash->{cmdStack}}; SWAP_Send($hash, $params->[0], $params->[1], $params->[2], $params->[3]); $sent = 1; $hash->{SWAP_CMDsPending} = scalar @{$hash->{cmdStack}}." CMDs_pending"; @@ -1232,8 +1234,10 @@ SWAP_Attr(@) my $i = 0; foreach my $endpoint ( @{$register->{endpoints}} ) { if( $endpoint->{units} ) { - my $factor = $endpoint->{units}->[0]->{factor} if( defined($endpoint->{units}->[0]->{factor}) ); - my $offset = $endpoint->{units}->[0]->{offset} if( defined($endpoint->{units}->[0]->{offset}) ); + my $factor; + $factor = $endpoint->{units}->[0]->{factor} if( defined($endpoint->{units}->[0]->{factor}) ); + my $offset; + $offset = $endpoint->{units}->[0]->{offset} if( defined($endpoint->{units}->[0]->{offset}) ); my $func = ""; $func .= "*$factor" if( defined($factor) && $factor != 1 ); $func .= "+$offset" if( defined($offset) && $offset > 0 );