From 7d72b28f202959af78d0fce7d34421e4f274bd7f Mon Sep 17 00:00:00 2001
From: markusbloch <>
Date: Mon, 10 Dec 2012 18:20:37 +0000
Subject: [PATCH] fixing unknown external_number issue

git-svn-id: https://svn.fhem.de/fhem/trunk/fhem@2312 2b470e98-0d58-463d-a4d8-8e2adae1ed80
---
 FHEM/72_FB_CALLMONITOR.pm | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/FHEM/72_FB_CALLMONITOR.pm b/FHEM/72_FB_CALLMONITOR.pm
index 131f8cf5e..8f78805a9 100755
--- a/FHEM/72_FB_CALLMONITOR.pm
+++ b/FHEM/72_FB_CALLMONITOR.pm
@@ -190,8 +190,8 @@ FB_CALLMONITOR_Read($)
   
    @array = split(";", $data);
   
-   $external_number = $array[3] if(not $array[3] eq "0" and $array[1] eq "RING");
-   $external_number = $array[5] if($array[1] eq "CALL");
+   $external_number = $array[3] if(not $array[3] eq "0" and $array[1] eq "RING" and $array[3] ne "");
+   $external_number = $array[5] if($array[1] eq "CALL" and $array[3] ne "");
   
    $external_number =~ s/^0// if(AttrVal($name, "remove-leading-zero", "0") eq "1");
   
@@ -209,11 +209,11 @@ FB_CALLMONITOR_Read($)
    }
    
    $reverse_search = FB_CALLMONITOR_reverseSearch($hash, $external_number) if(defined($external_number) and AttrVal($name, "reverse-search", "none") ne "none");
- 
+   
    readingsBeginUpdate($hash);
    readingsBulkUpdate($hash, "event", lc($array[1]));
-   readingsBulkUpdate($hash, "external_number", $external_number) if(defined($external_number));
-   readingsBulkUpdate($hash, "external_name", $reverse_search) if(defined($reverse_search)); 
+   readingsBulkUpdate($hash, "external_number", (defined($external_number) ? $external_number : "unknown"));
+   readingsBulkUpdate($hash, "external_name",(defined($reverse_search) ? $reverse_search : "unknown"));
    readingsBulkUpdate($hash, "internal_number", $array[4]) if($array[1] eq "RING" or $array[1] eq "CALL");
    readingsBulkUpdate($hash, "external_connection", $array[5]) if($array[1] eq "RING");
    readingsBulkUpdate($hash, "external_connection", $array[6]) if($array[1] eq "CALL");