From 85cca9da61c544133e13a8eb362b878eb9c8cfd2 Mon Sep 17 00:00:00 2001 From: KernSani Date: Tue, 15 Jan 2019 22:39:29 +0000 Subject: [PATCH] 44_ROLLO.pm: Small fix for external driving - more to come git-svn-id: https://svn.fhem.de/fhem/trunk/fhem@18274 2b470e98-0d58-463d-a4d8-8e2adae1ed80 --- FHEM/44_ROLLO.pm | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/FHEM/44_ROLLO.pm b/FHEM/44_ROLLO.pm index 689251e26..4ed9f2542 100644 --- a/FHEM/44_ROLLO.pm +++ b/FHEM/44_ROLLO.pm @@ -217,7 +217,7 @@ sub ROLLO_Set($@) { Log3 $name, 1, "ROLLO ($name) Set command \"position\" is deprecated. Please change your definitions to \"pct\""; } - my $desiredPos; + my $desiredPos; my $arg = ""; $arg = $a[2] if defined $a[2]; my $arg2 = ""; @@ -249,6 +249,7 @@ sub ROLLO_Set($@) { if ( $cmd eq "extern" ) { readingsSingleUpdate( $hash, "drive-type", "extern", 1 ); $cmd = $arg; + $arg = ""; } elsif ( $cmd eq "reset" ) { my $reset_pct = $pcts{$arg}; @@ -348,10 +349,11 @@ sub ROLLO_Set($@) { # Ich verstehe nicht wann nachfolgender Zustand eintreten kann, das Coding führt aber dazu, dass pct 0 (open) auf "none" gesetzt wird #$desiredPos = "none" if !$desiredPos || $desiredPos eq ""; } - #set desiredPos to avoid "uninitialized" message later (happens with "blocked" - KernSani 14.01.2019 - $desiredPos = ReadingsNum($name,"desired_pct",0) unless defined($desiredPos); - Log3 $name, 5, "ROLLO ($name) DesiredPos now $desiredPos, $cmd"; + #set desiredPos to avoid "uninitialized" message later (happens with "blocked" - KernSani 14.01.2019 + $desiredPos = ReadingsNum( $name, "desired_pct", 0 ) unless defined($desiredPos); + + Log3 $name, 5, "ROLLO ($name) DesiredPos now $desiredPos, $cmd"; #wenn ich gerade am fahren bin und eine neue Zielposition angefahren werden soll, # muss ich jetzt erst mal meine aktuelle Position berechnen und updaten