From ab1b9c9d0268f3539e789d327fcd75d1eaea54a8 Mon Sep 17 00:00:00 2001
From: markusbloch <>
Date: Tue, 12 Jan 2016 21:16:15 +0000
Subject: [PATCH] version: code optimization

git-svn-id: https://svn.fhem.de/fhem/trunk/fhem@10477 2b470e98-0d58-463d-a4d8-8e2adae1ed80
---
 FHEM/98_version.pm | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/FHEM/98_version.pm b/FHEM/98_version.pm
index 102fd4650..7f5973f5d 100755
--- a/FHEM/98_version.pm
+++ b/FHEM/98_version.pm
@@ -29,9 +29,8 @@ CommandVersion($$)
     next if(grep(/$mod_name/, @ret));
     Log 4, "Looking for SVN Id in module $mod_name";
 
-    if($max < length($mod_name)) {
-      $max = length($mod_name)
-    }
+    $max = length($mod_name) if($max < length($mod_name))
+
     my $line;
     
     if(!open(FH, $fn)) {
@@ -53,10 +52,8 @@ CommandVersion($$)
     push @ret, $line;
   }
   
-  @ret = map {/\$Id\: (\S+) (\S+) (.+?) \$/ ? sprintf("%-".$max."s %5d %s",$1,$2,$3) : $_}
-        @ret; 
-  @ret = grep {(defined($param) ? $_ =~ /$param/ : 1)} @ret;
-  @ret = sort {version_sortModules($a, $b)} @ret;
+  @ret = map {/\$Id\: (\S+) (\S+) (.+?) \$/ ? sprintf("%-".$max."s %5d %s",$1,$2,$3) : $_} @ret; 
+  @ret = sort {version_sortModules($a, $b)} grep {(defined($param) ? $_ =~ /$param/ : 1)} @ret;
   return "no loaded modules found that match: $param" if($param && !@ret);
   return sprintf("%-".$max."s %s","File","Rev   Last Change\n\n").
          trim(join("\n",  grep (($_ =~ /^fhem.pl|\d\d_/), @ret))."\n\n".