From c1f006afd3f439e7419ad85ac56b90912f53b4d7 Mon Sep 17 00:00:00 2001
From: Skjall <>
Date: Sun, 8 Mar 2020 12:18:37 +0000
Subject: [PATCH] 36_Vallox: Fixed MultiReading Issue

git-svn-id: https://svn.fhem.de/fhem/trunk@21377 2b470e98-0d58-463d-a4d8-8e2adae1ed80
---
 fhem/CHANGED           | 1 +
 fhem/FHEM/36_Vallox.pm | 8 ++++----
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/fhem/CHANGED b/fhem/CHANGED
index bb62b13b2..a2ffba8b1 100644
--- a/fhem/CHANGED
+++ b/fhem/CHANGED
@@ -1,5 +1,6 @@
 # Add changes at the top of the list. Keep it in ASCII, and 80-char wide.
 # Do not insert empty lines here, update check depends on it.
+ - bugfix:  36_Vallox: Fixed MultiReading Issue
  - feature: 70_BRAVIA: add requestReboot (thx schnakker)
  - change:  57_SSCal: commandref reviewed
  - feature: 98_RandomTimer: Add offState attribute to e.g. evaluate state
diff --git a/fhem/FHEM/36_Vallox.pm b/fhem/FHEM/36_Vallox.pm
index c138e430f..532e9489d 100644
--- a/fhem/FHEM/36_Vallox.pm
+++ b/fhem/FHEM/36_Vallox.pm
@@ -5,7 +5,7 @@
 #
 # @Author Skjall
 # @Created 21.07.2016 10:18:23
-# @Version 1.6.1
+# @Version 1.6.2
 #
 #  The modul reads and writes parameters via RS485 from and to a Vallox
 #  ventilation bus.
@@ -1734,7 +1734,7 @@ sub Vallox_Set($@) {
     {
 
         # TODO: Integrate get before set;
-        if ($hash->{ "MR_" . $Vallox_multiReadingTable_realcmd{$cmd} } ) {
+        if (!$hash->{ "MR_" . $Vallox_multiReadingTable_realcmd{$cmd} } ) {
             return
                 "Vallox: Internal "
               . $Vallox_multiReadingTable_realcmd{$cmd}
@@ -1745,11 +1745,11 @@ sub Vallox_Set($@) {
               . " first!";
         }
 
-        $arg = Vallox_ReplaceBit(
+        $arg = sprintf("%02x", oct("0b".Vallox_ReplaceBit(
             $hash,
             $hash->{ "MR_" . $Vallox_multiReadingTable_realcmd{$cmd} },
             $Vallox_multiReadingTable_digit{$cmd}, $arg
-        );
+        )));
         $cmd = $Vallox_multiReadingTable_realcmd{$cmd};
     }