From cd90b4adc7091a3229a8bebc4c1477a758edb633 Mon Sep 17 00:00:00 2001 From: delmar <> Date: Wed, 6 Nov 2019 19:51:19 +0000 Subject: [PATCH] 70_CanOverEthernet: fixed uninitialized value warning git-svn-id: https://svn.fhem.de/fhem/trunk/fhem@20466 2b470e98-0d58-463d-a4d8-8e2adae1ed80 --- CHANGED | 1 + FHEM/70_CanOverEthernet.pm | 8 +++++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/CHANGED b/CHANGED index 02df92e7b..9aa094640 100644 --- a/CHANGED +++ b/CHANGED @@ -1,5 +1,6 @@ # Add changes at the top of the list. Keep it in ASCII, and 80-char wide. # Do not insert empty lines here, update check depends on it. + - update: 70_CanOverEthernet: fixed uninitialized value warning - update: 71_ZM_Monitor: improved writing of model internal - bugfix: 70_ZoneMinder: fixed uninitialized value warnings - feature: 74_XiaomiBTLESens: code implementation for ClearGrassSens diff --git a/FHEM/70_CanOverEthernet.pm b/FHEM/70_CanOverEthernet.pm index e2436feb5..3835a9fca 100644 --- a/FHEM/70_CanOverEthernet.pm +++ b/FHEM/70_CanOverEthernet.pm @@ -231,9 +231,15 @@ sub CanOverEthernet_sendDataAnalog { my @pageVals; my @pageTypes; for ( my $valIndex=0; $valIndex < 4; $valIndex++ ) { - Log3 $name, 4, "CanOverEthernet ($name) - value $valIndex = $values[$pageIndex][$valIndex] type=$types[$pageIndex][$valIndex]"; my $val = $values[$pageIndex][$valIndex]; my $type = $types[$pageIndex][$valIndex]; + + if ( ! defined $val || ! defined $type ) { + Log3 $name, 4, "CanOverEthernet ($name) - page $pageIndex value $valIndex has no type or no value set. Skipping."; + next; + } + + Log3 $name, 4, "CanOverEthernet ($name) - value $valIndex = $values[$pageIndex][$valIndex] type=$types[$pageIndex][$valIndex]"; $pageVals[$valIndex] = CanOverEthernet_getValue( $name, $val ); $pageTypes[$valIndex] = ( defined $type ? $type : 0); }